メモリーリークの改善 #125
Open
メモリーリークの改善 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
なんか英語で説明書かれてる。。。まぁ、別に間違ったことは書いてないのですが日本語で。 Sora から weak_connections_ とその関連コードは取り除きました。Sora 破棄前に SoraConnection をガベージコレクタに巡回させる役割を担っていたかと思いますが、結局インスタンスが破棄できなくなってしまいインスタンスリークを引き起こしていたので、取り除くこととしました。 しかし、それでは SoraFactory が SoraSignaling より先に破棄されてしまってセグメンテーション違反を引き起こす問題が解決しないため、 SoraFactory を unique_ptr から shared_ptr に変えて SoraConnection からも参照させることで維持することでセグメンテーション違反を発生させないようにしました。 結局は以前、まぁこの方法なら起きなくはなるよね。と言っていた奥の手になります。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
e2e-test.ymlworkflow configuration and theSoraandSoraConnectionclasses to improve memory management and simplify the codebase. The most important changes include updates to the workflow triggers, modifications to theSoraandSoraConnectionconstructors, and removal of unused code.Workflow configuration updates:
.github/workflows/e2e-test.yml: Addedfeature/fix-memoryleak3branch to thepushevent and includedpushin the job conditions to ensure the workflow runs on pushes to this branch. [1] [2] [3] [4]Codebase simplification and memory management improvements:
src/sora.cpp: ModifiedSora::CreateConnectionto passfactory_toSoraConnectionand removed the management ofweak_connections_. [1] [2]src/sora.h: Changedfactory_to ashared_ptrand removedweak_connections_from theSoraclass. [1] [2]src/sora_connection.cpp: UpdatedSoraConnectionconstructor to accept ashared_ptr<SoraFactory>and setconn_andfactory_tonullptrin the destructor. [1] [2]src/sora_connection.h: Addedfactory_as a member ofSoraConnectionand updated the constructor to accept it. [1] [2] [3]src/sora_sdk_ext.cpp: Removedsora_tp_traverseandsora_tp_clearfunctions and their associated type slots, simplifying theSoraclass definition. [1] [2]